Thread (1 message) 1 message, 1 author, 2012-01-09

Re: Bug in smsc911x_init

From: <hidden>
Date: 2012-01-09 17:23:20

Hi
I've found that commit 3ac3546e5f17248d961ef0f4a27e75564bf71578, 
"net/smsc911x: Always wait for the chip to be ready" can cause init to 
fail. I am working on an out of tree board, but it will affect other 
users. With an smsc 9218 connected to a big endian processor using a 
16-bit bus, we have to wait for the value read from PMT_CTRL to be 0x10000 
rather than 0x1.
However, I am not sure what the correct test should be, as the data 
sheet states that you can't read or write to any other reg until the 
PMT_CTRL READY bit is set. Maybe we can poll until we get a valid result 
from reading BYTE_TEST, and then wait for the PMT_CTRL (endian specific) 
READY bit?

Whoops... please ignore. The problem was one of platform config data. For 
some reason this was set to SMSC911X_USE_32BIT, and somehow everything 
else except this new code in init works just fine.

Sorry about that,
Phil
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help