RE: [net-next 08/11] e1000e: add Receive Packet Steering (RPS) support

-----Original Message-----
From: David Miller [mailto:davem@davemloft.net]
Sent: Tuesday, January 03, 2012 12:10 PM
To: Kirsher, Jeffrey T
Cc: Allan, Bruce W; netdev@vger.kernel.org; gospo@redhat.com;
sassmann@redhat.com
Subject: Re: [net-next 08/11] e1000e: add Receive Packet Steering (RPS) support

From: Jeff Kirsher <redacted>
Date: Tue,  3 Jan 2012 11:19:13 -0800

quoted

+		e_err("Enabling both receive checksum offload and receive hashing is

not possible with jumbo frames.  Disable jumbos or enable only one of the
receive offload features.\n");

Please split this up into multiple lines like this:

e_err("..."
      "..."
      "...");

Thanks.

I was under the impression from recently accepted patches that the preferred
method for log/error message strings was to keep them as a single string
(rather than broken across multiple lines) for easy searching.  Is that not
the case here?

From ./Documentation/CodingStyle..."never break user-visible strings such as

printk messages, because that breaks the ability to grep for them."

Do you still want this change?

Thanks,
Bruce.