RE: [PATCH 0/4] skb paged fragment destructors
From: David Laight <hidden>
Date: 2012-01-03 09:38:18
From: David Laight <hidden>
Date: 2012-01-03 09:38:18
-#if (65536/PAGE_SIZE + 2) < 16 +#if (65536/PAGE_SIZE + 1) < 16 #define MAX_SKB_FRAGS 16UL #else -#define MAX_SKB_FRAGS (65536/PAGE_SIZE + 2) +#define MAX_SKB_FRAGS (65536/PAGE_SIZE + 1) #endif
Wouldn't it be better to only have the expression once? Either using a MAX() define or maybe: #define MAX_SKB_FRAGS (65536UL/PAGE_SIZE + 1) #if MAX_SKB_FRAGS < 16UL #undef MAX_SKB_FRAGS #define MAX_SKB_FRAGS 16UL #endif Although that replicates the 16 instead :-( David