Re: [PATCH net-next v2 2/4] can: cc770: add legacy ISA bus driver for the CC770 and AN82527
From: Wolfgang Grandegger <hidden>
Date: 2011-12-12 11:55:52
Also in:
linux-can
On 12/12/2011 12:18 PM, Wolfgang Zarre wrote:
Hello Wolfgang,quoted
Hi Wolfgang, On 12/11/2011 07:33 PM, Wolfgang Zarre wrote:quoted
Hello Wolfgang,quoted
On 12/07/2011 02:42 PM, Wolfgang Grandegger wrote:quoted
Hi Wolfgang, On 12/06/2011 10:08 PM, Wolfgang Zarre wrote:...quoted
quoted
quoted
quoted
Let me know if You need more or some other tests.You could provoke some state changes or bus-off conditions to see if the berr-counter shows reasonable results. I'm currently consolidating and unifying error state and bus-off handling. Would be nice if you could do some further tests when I have the patches ready...I just pushed the mentioned modifications to the "devel" branch of my "wg-linux-can-next" [1] repository. You can get it as shown below: $ git clone --reference=<some-recent-net-next-tree> \ git://gitorious.org/~wgrandegger/linux-can/wg-linux-can-next.git $ git checkout -b devel devel [1] https://gitorious.org/~wgrandegger/linux-can/wg-linux-can-next Wolfgang.OK, I was trying so far and You will find below the results. Just FYI the states on the PLC side couldn't be verified because the function provided by the manufacturer is not working at all and CAN analyser was not available. We are running CANopen and therefore the PLC will send automatically a heartbeat. I produced the bus-off state through a short circuit between L/H which was working as expected. A bit odd was that on the second try I had to reload the module because a ip down/up was not enough.Oops, not good.But might be in connection with the strange behaviour of the PLC.
It's a bug! netif_start_queue is missing at the end of the open function. Got lost some how. I have just updated (rebased!) my wg-linux-can-next repository. Wolfgang.