Thread (5 messages) flat view 5 messages, 4 authors, 2011-12-15

Re: [PATCH 1/1] r8169.c correct MSIEnable register offset

From: David Miller <davem@davemloft.net>
Date: 2011-12-15 06:47:14
Also in: lkml

From: Francois Romieu <romieu@fr.zoreil.com>
Date: Wed, 14 Dec 2011 22:37:13 +0100
Su Kang Yin [off-list ref] :
quoted
correct MSIEnable (bit 5) register to Config1 (offset 0x52) instead of
Config2 (offset 0x53)
I wonder where the inspiration for the MSIEnable bit came from.
It looks like something was confused with the Message Control word
in PCI space.

Imho you can simply remove it altogether.
Someone should find out what the real situation is with this.

Maybe it mirrors the PCI config space setting and is read-only, maybe
not.  But it should be determined for sure before changing this. :-)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help