Re: [PATCH 1/4] nfc: Use standard logging styles

On Thu, 2011-12-01 at 16:59 +0100, Samuel Ortiz wrote:

Hi Joe,

Hello Samuel.

On Tue, Nov 29, 2011 at 11:37:32AM -0800, Joe Perches wrote:

quoted

Using the normal logging styles is preferred over
subsystem specific styles when the subsystem does
not take a specific struct.
Convert nfc_<level> specific messages to pr_<level>
Add newlines to uses.

I would be fine with moving to pr_debug, but I'd like the pr_fmt() routine to
include the function name as well.

If you really want it I can add it back but
if you are not aware, dynamic debug can add
this by using:

echo "module nfc +fp" > <debugfs>/dynamic_debug/control
echo "module nci +fp" > <debugfs>/dynamic_debug/control

If you're getting dmesg logs from customers
that's a bit harder to track though.