Re: [PATCH] genetlink: add auto module loading
From: David Miller <davem@davemloft.net>
Date: 2011-12-28 19:03:17
From: David Miller <davem@davemloft.net>
Date: 2011-12-28 19:03:17
From: Stephen Hemminger <redacted> Date: Wed, 28 Dec 2011 11:02:08 -0800
On Wed, 28 Dec 2011 13:49:39 -0500 (EST) David Miller [off-list ref] wrote:quoted
From: Stephen Hemminger <redacted> Date: Wed, 28 Dec 2011 10:19:58 -0800quoted
When testing L2TP support, I discovered that the l2tp module is not autoloaded as are other netlink interfaces. There is because of lack of hook in genetlink to call request_module and load the module. Signed-off-by: Stephen Hemminger <redacted>Applied, but for completeness we should probably also handle the "by ID" case right above this code block too. Could you please submit a patch for that? Thanks.There is no point really. All the existing drivers, use GENL_ID_GENERATE which generates the ID when they are loaded. Chicken and egg principle.
Ok, then I wonder why we support ID based lookups at all.