Thread (9 messages) 9 messages, 3 authors, 2011-12-29

Re: [PATCH] skge: restore multicast rx filter on resume

From: Florian Zumbiehl <hidden>
Date: 2011-12-28 07:41:52
Subsystem: networking drivers, the rest · Maintainers: Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds

Hi,
quoted
quoted
diff --git a/drivers/net/skge.c b/drivers/net/skge.c
index f4be5c7..cd968e5 100644
--- a/drivers/net/skge.c
+++ b/drivers/net/skge.c
@@ -4046,6 +4046,7 @@ static int skge_resume(struct device *dev)
 				dev_close(dev);
 				goto out;
 			}
+			skge_set_multicast(dev);
 		}
 	}
 out:
Right idea, but it needs to be done in a different spot to catch
all the other device restart cases like changing settings.
Roughly like this maybe? (Successfully tested with an MTU change ...)

Florian

---------------------------------------------------------------------------
skge: restore rx multicast filter on resume

Signed-off-by: Florian Zumbiehl <redacted>
diff --git a/drivers/net/skge.c b/drivers/net/skge.c
index f4be5c7..8f985a8 100644
--- a/drivers/net/skge.c
+++ b/drivers/net/skge.c
@@ -2587,6 +2587,9 @@ static int skge_up(struct net_device *dev)
 	spin_unlock_irq(&hw->hw_lock);
 
 	napi_enable(&skge->napi);
+
+	skge_set_multicast(dev);
+
 	return 0;
 
  free_rx_ring:
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help