Thread (4 messages) 4 messages, 3 authors, 2012-01-05

Re: [PATCH 02/14 v2] mac802154: allocation of ieee802154 device

From: David Miller <davem@davemloft.net>
Date: 2011-12-28 07:31:50

From: Alexander Smirnov <redacted>
Date: Wed, 28 Dec 2011 10:19:23 +0300
Dear David,

2011/12/26 David Miller [off-list ref]:
quoted
From: Alexander Smirnov <redacted>
Date: Mon, 26 Dec 2011 20:04:07 +0300
quoted
+     /*
+      * SoftMAC device is registered and running. One can add
+      * subinterfaces.
+      */
+     unsigned running:1;
I told you to change this to a 'bool' in my previous review of your changes.

I'm pretty much going to stop reviewing right here, because I don't
want to waste my time only to find out that you've ignored other
review feedback I've already given to you.
Regarding your comments to my previous post, none of them was omitted. I
reworked code according to them and added extended comments in a patch
explaining why I can't follow your hint. The issue with 'bool' you marked
was in another patch (#14) which I already fixed.
My bad, I thought I had asked you do it here too.

Sorry about that.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help