Re: [PATCH] net: meth: Add set_rx_mode hook to fix ICMPv6 neighbor discovery

From: Stephen Hemminger <redacted>
Date: Tue, 27 Dec 2011 10:34:08 -0800

On Tue, 27 Dec 2011 00:06:15 -0500
Joshua Kinard [off-list ref] wrote:

quoted

@@ -95,7 +95,7 @@ struct mace_video {
  * Ethernet interface
  */
 struct mace_ethernet {
-	volatile unsigned long mac_ctrl;
+	volatile u64 mac_ctrl;
 	volatile unsigned long int_stat;
 	volatile unsigned long dma_ctrl;
 	volatile unsigned long timer;

This device driver writer needs to read:
  Documentation/volatile-considered-harmful.txt

This driver has a lot of problems, some of which I've made Joshua aware of
already.