Thread (22 messages) flat view 22 messages, 6 authors, 2011-12-30

Re: netem and hierarchical ingress traffic shaping

From: Dave Taht <hidden>
Date: 2011-12-23 18:54:09

On Fri, Dec 23, 2011 at 7:28 PM, Eric Dumazet [off-list ref] wrote:
Le vendredi 23 décembre 2011 à 18:54 +0100, Dave Taht a écrit :
quoted
Are there any place where all 48 bytes of cb are used?
Yes, but on in qdisc layer.

struct tcp_skb_cb is known to be 44 bytes (when IPv6 is enabled)

In qdisc layer, we use a small part of it, for the moment.
quoted
I wouldn't mind if 'time_to_send' became a separate skb field
for a more generic 'time_in_queue'...
This wont happen.

As I posted in an earlier patch, this can be added in "struct
qdisc_skb_cb"
Ah... this patch?

http://patchwork.ozlabs.org/patch/125329/

I liked what I saw then, but nobody chirped up to review it...

I guess I know what I'm doing this weekend.


-- 
Dave Täht
SKYPE: davetaht
US Tel: 1-239-829-5608
FR Tel: 0638645374
http://www.bufferbloat.net
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help