Thread (1 message) 1 message, 1 author, 2011-12-19

Re: [PATCH 10/14] ieee802154: interface type to be added

From: David Miller <hidden>
Date: 2011-12-19 19:42:10

From: Alexander Smirnov <redacted>
Date: Mon, 19 Dec 2011 19:33:50 +0300
 	int rc = -ENOBUFS;
 	struct net_device *dev;
+        int type = -EINVAL;
Bad indentation.

Or do you mean to tell me this doesn't look like total garbage and
stand out like a sore thumb on your computer screen?
+		if (type > __IEEE802154_DEV_MAX) {
+			return -EINVAL;
+		}
No need for openning and closing braces here, there is simply one
statement in the basic block.

If you'll need them later, add them later, not now.

------------------------------------------------------------------------------
Learn Windows Azure Live!  Tuesday, Dec 13, 2011
Microsoft is holding a special Learn Windows Azure training event for 
developers. It will provide a great way to learn Windows Azure and what it 
provides. You can attend the event by watching it streamed LIVE online.  
Learn more at http://p.sf.net/sfu/ms-windowsazure
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help