Re: [PATCH net-next] r8169: Support for byte queue limits
From: Eric Dumazet <hidden>
Date: 2011-12-19 10:20:00
Possibly related (same subject, not in this thread)
- 2011-12-19 · Re: [PATCH net-next] r8169: Support for byte queue limits · David Miller <davem@davemloft.net>
- 2011-12-19 · [PATCH net-next] r8169: Support for byte queue limits · <hidden>
- 2011-12-19 · Re: [PATCH net-next] r8169: Support for byte queue limits · Igor Maravić <hidden>
- 2011-12-19 · Re: [PATCH net-next] r8169: Support for byte queue limits · Eric Dumazet <hidden>
- 2011-12-19 · Re: [PATCH net-next] r8169: Support for byte queue limits · Igor Maravić <hidden>
Le lundi 19 décembre 2011 à 11:09 +0100, igorm@etf.rs a écrit :
quoted hunk ↗ jump to hunk
From: Igor Maravic <redacted> Changes to r8169 to use byte queue limits. Signed-off-by: Igor Maravic <redacted> --- drivers/net/ethernet/realtek/r8169.c | 13 +++++++++++-- 1 files changed, 11 insertions(+), 2 deletions(-)diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index 36b2a4b..1a6a12a 100644 --- a/drivers/net/ethernet/realtek/r8169.c +++ b/drivers/net/ethernet/realtek/r8169.c@@ -5326,6 +5326,7 @@ static void rtl8169_tx_clear(struct rtl8169_private *tp) { rtl8169_tx_clear_range(tp, tp->dirty_tx, NUM_TX_DESC); tp->cur_tx = tp->dirty_tx = 0; + netdev_reset_queue(tp->dev); } static void rtl8169_schedule_work(struct net_device *dev, work_func_t task)@@ -5546,6 +5547,8 @@ static netdev_tx_t rtl8169_start_xmit(struct sk_buff *skb, tp->cur_tx += frags + 1; + netdev_sent_queue(dev, skb->len); +
Hmm, thats a bit too late here. An interrupt could theorically free skb right before your deref.
quoted hunk ↗ jump to hunk
wmb(); RTL_W8(TxPoll, NPQ);@@ -5624,6 +5627,8 @@ static void rtl8169_tx_interrupt(struct net_device *dev,
I believe its better to access skb _before_ the txd->opts2 = cpu_to_le32(opts[1]); wmb();