[PATCH 2/3] cdc_ether: allow vendor specific data interface if control interface is vendor specific
DORMANTno replies
From: Bjorn Mork <hidden>
Date: 2011-12-13 04:33:03
Subsystem:
networking drivers, the rest, usb cdc ethernet driver, usb networking drivers · Maintainers:
Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds, Oliver Neukum
Possibly related (same subject, not in this thread)
- 2011-12-13 · Re: [PATCH 2/3] cdc_ether: allow vendor specific data interface if control interface is vendor specific · Sergei Shtylyov <hidden>
- 2011-12-13 · Re: [PATCH 2/3] cdc_ether: allow vendor specific data interface if control interface is vendor specific · Bjørn Mork <hidden>
- 2011-12-13 · Re: [PATCH 2/3] cdc_ether: allow vendor specific data interface if control interface is vendor specific · Joe Perches <hidden>
From: Bjørn Mork <redacted> Some vendors, like Huawei, use the vendor specific class code all over the place even for devices which otherwise conform pretty well to the CDC ECM specification. This allows such devices to be supported merely by adding them to the device specific whitelist. Signed-off-by: Bjørn Mork <redacted> --- drivers/net/usb/cdc_ether.c | 8 ++++++-- 1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/net/usb/cdc_ether.c b/drivers/net/usb/cdc_ether.c
index 99ed6eb..84840dd 100644
--- a/drivers/net/usb/cdc_ether.c
+++ b/drivers/net/usb/cdc_ether.c@@ -211,8 +211,12 @@ int usbnet_generic_cdc_bind(struct usbnet *dev, struct usb_interface *intf) /* a data interface altsetting does the real i/o */ d = &info->data->cur_altsetting->desc; - if (d->bInterfaceClass != USB_CLASS_CDC_DATA) { - dev_dbg(&intf->dev, "slave class %u\n", + if ((d->bInterfaceClass != USB_CLASS_CDC_DATA) && + /* Allow vendor specific data interface iff + control interface is vendor specific */ + !(info->control->cur_altsetting->desc.bInterfaceClass == USB_CLASS_VENDOR_SPEC && + d->bInterfaceClass == USB_CLASS_VENDOR_SPEC)) { + dev_dbg(&intf->dev, "xslave class %u\n", d->bInterfaceClass); goto bad_desc; }
--
1.7.7.3
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html