On Tue, 2011-12-06 at 15:21 +0800, Jason Wang wrote:

On 12/06/2011 04:09 AM, Ben Hutchings wrote:

quoted

On Mon, 2011-12-05 at 16:58 +0800, Jason Wang wrote:

quoted

This patch adds a simple flow director to tun/tap device. It is just a
page that contains the hash to queue mapping which could be changed by
user-space. The backend (tap/macvtap) would query this table to get
the desired queue of a packets when it send packets to userspace.

This is just flow hashing (RSS), not flow steering.

quoted

The page address were set through a new kind of ioctl - TUNSETFD and
were pinned until device exit or another new page were specified.

[...]

You should implement ethtool ETHTOOL_{G,S}RXFHINDIR instead.

Ben.

I'm not fully understanding this. The page belongs to guest, and the 
idea is to let guest driver can easily change any entry. Looks like if 
ethtool_set_rxfh_indir() is used, this kind of change is not easy as it 
needs one copy and can only accept the whole table as its parameters.

Sorry, yes, I was misreading this.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.