RE: [PATCH net-next V0 18/21] mlx4_core: adjust catas operation for SRIOV mode

On Fri, Dec 2, 2011 at 2:19 AM, Yevgeny Petrilin
[off-list ref] wrote:

quoted

When running in SRIOV mode, driver should not automatically

start/stop

quoted

the mlx4_core upon sensing an HCA internal error -- doing this

disables/enables

quoted

sriov, which will cause the hypervisor to hang if there are running

VMs with

quoted

attached VFs.

Not sure I understand this -- what happens if the driver doesn't reset
the device
after a catastrophic error?  Surely all the VFs are pretty screwed at
that point?

Which hypervisor are we talking about here anyway?

 - R.

Indeed, if you don't reset the device after an internal error, the PF/VF might not work properly unless you reload the PF driver.

However, invoking the SW reset by the PF (upon detecting an internal error) currently affects the SRIOV capability on the PCI so we cannot do it before disabling SRIOV first.
Since the driver is not in charge of passing-through VFs to VMs, it cannot disable SRIOV either so we cannot reset the device while using SRIOV.
Note that the single-function behavior is not modified.

We intend to post a fix for this in a different patch-set.
--Liran

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html