Thread (15 messages) 15 messages, 3 authors, 2011-12-05

Re: [net-next 1/6] e1000e: Avoid wrong check on TX hang

flat view

From: Jeff Kirsher <hidden>
Date: 2011-12-04 07:28:37

On Sat, 2011-12-03 at 19:26 -0800, David Miller wrote:
From: Jeff Kirsher <redacted>
Date: Sat,  3 Dec 2011 03:44:26 -0800
quoted
+	if ((!adapter->tx_hang_recheck) &&
Excessive parenthesis, please remove.
quoted
+		adapter->tx_hang_recheck = 1;
This variable is a bool, set it to true or false.
quoted
+			adapter->tx_hang_recheck = 0;
Likewise.
quoted
+	adapter->tx_hang_recheck = 0;
Likewise.
Michael/Flavio -

To expedite this patch, I can make the changes that Dave is requesting
and re-submit v2 of the patch, if that is ok with you.

-Jeff

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help