Re: [PATCH 0/2] clean up tx_bytes accounting

On Thu, Nov 03, 2011 at 03:27:38PM +0100, Oliver Hartkopp wrote:

On 03.11.2011 11:42, Marc Kleine-Budde wrote:

quoted

On 11/03/2011 11:03 AM, Kurt Van Dijck wrote:

quoted

On Thu, Nov 03, 2011 at 10:47:53AM +0100, Marc Kleine-Budde wrote:

quoted

Hello,

what about turning can_get_echo_skb() into a helper function which returns the number
of tx'ed bytes.

That would work.

Next step would be to do the statistics inside can_get_echo_skb(), but that's
affecting all drivers using it ...
Kurt

Interesting idea

Yes, but then the name of the function is not appropriate anymore.

The return value for can_get_echo_skb() gives a silent improvement that can be
adopted by CAN drivers by the time. But hiding more functionality inside this
function may lead to misunderstandings.

That's what I described with the obscure phrase "..." :-)

Marc's proposed patch is indeed easier to digest at the time.

Regards,
Kurt