Re: [PATCH V2 01/14] clk: add helper functions clk_prepare_enable and clk_disable_unprepare
From: Sascha Hauer <s.hauer@pengutronix.de>
Date: 2011-11-11 08:49:50
Also in:
linux-arm-kernel, linux-i2c, linux-mmc, linux-serial
On Fri, Nov 11, 2011 at 09:10:16AM +0800, Richard Zhao wrote:
quoted hunk ↗ jump to hunk
Signed-off-by: Richard Zhao <redacted> --- include/linux/clk.h | 19 +++++++++++++++++++ 1 files changed, 19 insertions(+), 0 deletions(-)diff --git a/include/linux/clk.h b/include/linux/clk.h index 7213b52..63985f7 100644 --- a/include/linux/clk.h +++ b/include/linux/clk.h@@ -107,6 +107,25 @@ static inline void clk_unprepare(struct clk *clk) } #endif +static inline int clk_prepare_enable(struct clk *clk) +{ + int ret; + + ret = clk_prepare(clk); + if (!ret) + ret = clk_enable(clk); + if (ret) + clk_unprepare(clk);
As Baruch already pointed out this is hard to read. Also it contains a bug. When clk_prepare fails clk_unprepare is called afterwards. Hint: Kernel guys are not afraid of having multiple return statements in a function, instead they like it when something is handled early without having to read the rest of the function. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |