RE: [PATCH 4/5] NFS: remove RPC PipeFS mount point reference from blocklayout routines
From: Myklebust, Trond <hidden>
Date: 2011-11-29 13:36:18
Also in:
linux-nfs, lkml
-----Original Message----- From: tao.peng@emc.com [mailto:tao.peng@emc.com] Sent: Tuesday, November 29, 2011 7:40 AM To: skinsbursky@parallels.com Cc: Myklebust, Trond; linux-nfs@vger.kernel.org; xemul@parallels.com; neilb@suse.de; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; jbottomley@parallels.com; bfields@fieldses.org; davem@davemloft.net; devel@openvz.org Subject: RE: [PATCH 4/5] NFS: remove RPC PipeFS mount point reference from blocklayout routinesquoted
-----Original Message----- From: Stanislav Kinsbursky [mailto:skinsbursky@parallels.com] Sent: Tuesday, November 29, 2011 8:19 PM To: Peng, Tao Cc: Trond.Myklebust@netapp.com; linux-nfs@vger.kernel.org; Pavel Emelianov; neilb@suse.de; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; James Bottomley; bfields@fieldses.org; davem@davemloft.net; devel@openvz.org Subject: Re: [PATCH 4/5] NFS: remove RPC PipeFS mount point reference from blocklayout routines 29.11.2011 16:00, tao.peng@emc.com пишет:quoted
quoted
-----Original Message----- From: linux-nfs-owner@vger.kernel.org [mailto:linux-nfs-owner@vger.kernel.org] On Behalf OfStanislavquoted
quoted
Kinsbursky Sent: Tuesday, November 29, 2011 6:11 PM To: Trond.Myklebust@netapp.com Cc: linux-nfs@vger.kernel.org; xemul@parallels.com; neilb@suse.de; netdev@vger.kernel.org; linux- kernel@vger.kernel.org; jbottomley@parallels.com; bfields@fieldses.org; davem@davemloft.net; devel@openvz.org Subject: [PATCH 4/5] NFS: remove RPC PipeFS mount point reference from blocklayout routines This is a cleanup patch. We don't need this reference anymore, because blocklayout pipes dentries now creates and destroys in per-net operations and on PipeFS mount/umount notification. Note that nfs4blocklayout_register_net() now returns 0 instead of -ENOENT in case of PipeFS superblock absence. This is ok, because blocklayout pipe dentry will be created on PipeFS mount event.When is the "pipefs mount event" going to happen? When inserting kernel modules or when user issuesmount command?quoted
When user issues mount command. Kernel mounts of PipeFS has been removed with all these patch sets I've sent already.Then it is going to break blocklayout user space program blkmapd, which is stared before mounting any file system and it tries to open the pipe file when started.
Why on earth is blkmapd doing this instead of listening for file creation notifications like the other rpc_pipefs daemons do? Trond