Re: [PATCH v6 04/10] Account tcp memory as kernel memory
From: KAMEZAWA Hiroyuki <hidden>
Date: 2011-11-28 03:15:55
Also in:
cgroups, linux-mm, lkml
Some nitpicks. On Fri, 25 Nov 2011 15:38:10 -0200 Glauber Costa [off-list ref] wrote:
Now that we account and control tcp memory buffers memory for pressure controlling purposes, display this information as part of the normal memcg files and other usages.
quoted hunk ↗ jump to hunk
+extern struct mem_cgroup *mem_cgroup_from_cont(struct cgroup *cont); +extern struct mem_cgroup *parent_mem_cgroup(struct mem_cgroup *mem); + static inline int mm_match_cgroup(const struct mm_struct *mm, const struct mem_cgroup *cgroup) {diff --git a/include/net/sock.h b/include/net/sock.h index d802761..da38de2 100644 --- a/include/net/sock.h +++ b/include/net/sock.h@@ -65,6 +65,9 @@ #include <net/dst.h> #include <net/checksum.h> +int sockets_populate(struct cgroup *cgrp, struct cgroup_subsys *ss); +void sockets_destroy(struct cgroup *cgrp, struct cgroup_subsys *ss); + /*
Hmm, what is this 'populate' function for ? mem_cgroup_sockets_init() ?
quoted hunk ↗ jump to hunk
* This structure really needs to be cleaned up. * Most of it is for TCP, and not used by any ofdiff --git a/include/net/tcp_memcg.h b/include/net/tcp_memcg.h new file mode 100644 index 0000000..5f5e158 --- /dev/null +++ b/include/net/tcp_memcg.h@@ -0,0 +1,17 @@ +#ifndef _TCP_MEMCG_H +#define _TCP_MEMCG_H + +struct tcp_memcontrol { + struct cg_proto cg_proto; + /* per-cgroup tcp memory pressure knobs */ + struct res_counter tcp_memory_allocated; + struct percpu_counter tcp_sockets_allocated; + /* those two are read-mostly, leave them at the end */ + long tcp_prot_mem[3]; + int tcp_memory_pressure; +}; + +struct cg_proto *tcp_proto_cgroup(struct mem_cgroup *memcg); +int tcp_init_cgroup(struct cgroup *cgrp, struct cgroup_subsys *ss); +void tcp_destroy_cgroup(struct cgroup *cgrp, struct cgroup_subsys *ss); +#endif /* _TCP_MEMCG_H */diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 5f29194..2df5d3c 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c@@ -49,6 +49,8 @@ #include <linux/cpu.h> #include <linux/oom.h> #include "internal.h" +#include <net/sock.h> +#include <net/tcp_memcg.h>
ok, tcp_memcg.h ... some other men may like tcp_memcontrol.h..
#include <asm/uaccess.h>
<snip>
quoted hunk ↗ jump to hunk
static int alloc_mem_cgroup_per_zone_info(struct mem_cgroup *mem, int node)@@ -4954,7 +4983,7 @@ static void mem_cgroup_put(struct mem_cgroup *mem) /* * Returns the parent mem_cgroup in memcgroup hierarchy with hierarchy enabled. */ -static struct mem_cgroup *parent_mem_cgroup(struct mem_cgroup *mem) +struct mem_cgroup *parent_mem_cgroup(struct mem_cgroup *mem) { if (!mem->res.parent) return NULL;@@ -5037,6 +5066,7 @@ mem_cgroup_create(struct cgroup_subsys *ss, struct cgroup *cont) res_counter_init(&mem->res, &parent->res); res_counter_init(&mem->memsw, &parent->memsw); res_counter_init(&mem->kmem, &parent->kmem); +
unnecessary blank line.
quoted hunk ↗ jump to hunk
/* * We increment refcnt of the parent to ensure that we can * safely access it on res_counter_charge/uncharge.@@ -5053,6 +5083,7 @@ mem_cgroup_create(struct cgroup_subsys *ss, struct cgroup *cont) mem->last_scanned_node = MAX_NUMNODES; INIT_LIST_HEAD(&mem->oom_notify); +
ditto. <snip> Reviewed-by: KAMEZAWA Hiroyuki <redacted> -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>