Thread (3 messages) flat view 3 messages, 3 authors, 2011-11-26

Re: [PATCH 1/1] AF_UNIX: Fix poll locking problem when reading from a stream socket

From: David Miller <davem@davemloft.net>
Date: 2011-11-26 21:35:22
Also in: lkml

From: Eric Dumazet <redacted>
Date: Tue, 22 Nov 2011 06:23:01 +0100
Le mardi 22 novembre 2011 à 03:35 +0400, Alexey Moiseytsev a écrit :
quoted
poll() call may be locked by concurrent reading from the same stream
socket.

Signed-off-by: Alexey Moiseytsev <redacted>
 ..
Fine, the fix is technically correct since we own u->readlock mutex,
another thread cannot consume the just requeued skb. 

Small note : the words "locking" and "locked" are more used to describe
the action of taking a spinlock/mutex/rwlock or something, while the bug
you fixed is more about poll() system call being blocked/frozen forever.

Thanks !

Acked-by: Eric Dumazet <redacted>
Applied, with 'lock{ing,ed}' adjusted to 'block{ing,ed}'.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help