Thread (7 messages) 7 messages, 4 authors, 2011-11-24

Re: [PATCH 1/2] ax25: integer overflows in ax25_setsockopt()

From: Alan Cox <hidden>
Date: 2011-11-23 10:43:27
Also in: linux-hams, lkml

 	case AX25_T1:
-		if (opt < 1) {
+		if (opt < 1 || opt > 30) {
Where do these values come from ? If they are from some 'standard' then
really we should avoid restricting needlessly to it, particularly as
AX.25 isn't well defined and is used for all sorts of crazy stuff where
the usual range of settings isn't useful.

Restricting to the point it would overflow makes sense however.

Alan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help