Re: [PATCH 1/3] xfrm: add incoming interface to selector
From: David Miller <davem@davemloft.net>
Date: 2011-11-30 17:48:01
From: David Miller <davem@davemloft.net>
Date: 2011-11-30 17:48:01
From: Ulrich Weber <redacted> Date: Wed, 30 Nov 2011 18:33:54 +0100
On 30.11.2011 01:00, David Miller wrote:quoted
This isn't safe, because we have no idea if existing users are putting garbage there. So your change can break things. You'll have to add a netlink attribute or similar.But a implementation matching xfrm against UID would break existing programs too, where sel->user is set to garbage.
Such a program would have to be used with other agents which are known to not modify the sel->user of existing entries. I'm not letting you reassign this existing structure member for another use, it's been exposed to userspace for nearly 10 years.