Re: [PATCH net-next 4/4] net: Add Open vSwitch kernel components.
From: Jesse Gross <hidden>
Date: 2011-11-19 18:19:42
On Fri, Nov 18, 2011 at 5:37 PM, David Miller [off-list ref] wrote:
From: Stephen Hemminger <redacted> Date: Fri, 18 Nov 2011 17:09:17 -0800 (PST)quoted
quoted
On Fri, Nov 18, 2011 at 3:23 PM, Stephen Hemminger [off-list ref] wrote:quoted
On Fri, 18 Nov 2011 15:12:18 -0800 Jesse Gross [off-list ref] wrote:quoted
+ write_seqcount_begin(&stats->seqlock); + stats->tx_packets++; + stats->tx_bytes += sent; + write_seqcount_end(&stats->seqlock);There is a u64_stats_sync set of macros for this. It has the advantage of becoming a NOP on 64 bit platforms.The reason why I did it this way is it ties the packet and byte count together.Ok, but why bother? No other software counters bother to group bytes/packets. Even hardware counters get read separately.Agreed, this is totally pointless. Please use the u64 state interfaces.
That's fine, I'll change it. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev