On Wed, Nov 16, 2011 at 10:43:29PM +0000, Ben Hutchings wrote:

On Wed, 2011-11-16 at 02:29 +0100, Michał Mirosław wrote:

quoted

v2:	changed loop in ethtool_set_features() per Ben's suggestion

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>

Run checkpatch and fix the spacing complaints.  After that, consider
this:

There are two lines longer than 80 chars, but it won't improve readability
if I split them. No spacing complaints on my run of checkpatch:

WARNING: line over 80 characters
#51: FILE: net/core/ethtool.c:91:
+       BUILD_BUG_ON(ETHTOOL_DEV_FEATURE_WORDS*sizeof(u32) > sizeof(netdev_features_t));

WARNING: line over 80 characters
#57: FILE: net/core/ethtool.c:97:
+               features[i].never_changed = (u32)(NETIF_F_NEVER_CHANGE >> (32*i));

total: 0 errors, 2 warnings, 75 lines checked

/tmp/0007-ethtool-prepare-for-larger-netdev_features_t-type.patch has style problems, please review.

Best Regards,
Michał Mirosław