Re: [PATCHv4 4/9] macb: convert printk to netdev_ and friends
flat view
From: Joe Perches <joe@perches.com>
Date: 2011-11-09 13:46:09
On Wed, 2011-11-09 at 13:37 +0000, Jamie Iles wrote:
OK, here's an updated patch. Thanks again Joe!
Hi Jamie, thanks for updating, one possible thing.
quoted hunk ↗ jump to hunk
@@ -625,15 +625,12 @@ static int macb_start_xmit(struct sk_buff *skb, struct net_device *dev) #ifdef DEBUG int i; - dev_dbg(&bp->pdev->dev, - "start_xmit: len %u head %p data %p tail %p end %p\n", - skb->len, skb->head, skb->data, - skb_tail_pointer(skb), skb_end_pointer(skb)); - dev_dbg(&bp->pdev->dev, - "data:"); - for (i = 0; i < 16; i++) - printk(" %02x", (unsigned int)skb->data[i]); - printk("\n"); + netdev_dbg(bp->dev, + "start_xmit: len %u head %p data %p tail %p end %p\n", + skb->len, skb->head, skb->data, + skb_tail_pointer(skb), skb_end_pointer(skb)); + print_hex_dump(KERN_DEBUG, "data: ", DUMP_PREFIX_OFFSET, 16, 1, + skb->data, 16, true); #endif
I think there an unused variable "i" warning now if DEBUG is #defined.