Re: [PATCH v6 5/8] SUNRPC: cleanup service destruction

28.10.2011 01:30, J. Bruce Fields пишет:

On Tue, Oct 25, 2011 at 02:17:18PM +0300, Stanislav Kinsbursky wrote:

quoted

svc_unregister() call have to be removed from svc_destroy() since it will be
called in sv_shutdown callback.

It would be clearer that you're *moving* this if this were merged with
the following patch.  And without doing that the series isn't quite
bisectable, unless I'm missing something.

Yes, you are right. Will resend new version soon.

--b.

quoted

Signed-off-by: Stanislav Kinsbursky<redacted>

---
  net/sunrpc/svc.c |    1 -
  1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c
index 918edc3..407462f 100644
--- a/net/sunrpc/svc.c
+++ b/net/sunrpc/svc.c

@@ -530,7 +530,6 @@ svc_destroy(struct svc_serv *serv)
  	if (svc_serv_is_pooled(serv))
  		svc_pool_map_put();

-	svc_unregister(serv);
  	kfree(serv->sv_pools);
  	kfree(serv);
  }

-- 
Best regards,
Stanislav Kinsbursky