On Thu, Oct 27, 2011 at 09:45, Jeff Kirsher [off-list ref] wrote:

On Wed, 2011-10-26 at 22:16 -0700, Geert Uytterhoeven wrote:

quoted

On Tue, Oct 25, 2011 at 22:19, Geert Uytterhoeven
[off-list ref] wrote:

quoted

drivers/net/ethernet/apple/mac89x0.c is a driver for the Crystal

Semiconductor

quoted

(Now Cirrus Logic) CS89[02]0, so it belongs in

drivers/net/ethernet/cirrus,

quoted

next to cs89x0.c.

And on the first -next run since its inclusion:

| drivers/net/ethernet/apple/mac89x0.c:107:20: error: cs89x0.h: No
such file or directory

it needs the (shared) header file which is in
drivers/net/ethernet/cirrus/.

http://kisskb.ellerman.id.au/kisskb/buildresult/4835488/

Ah, yeah, now it is coming back to me why I placed cs89x0.[ch] in the
drivers/net/ethernet/apple/ because it was grouped with the "common"
drivers.  The intent was to group drivers that use common code together.

I can put together a patch to fix this if you are not able to.

I will create a patch to move mac89x0 to .../cirrus, when I get to compiling a
Mac kernel myself.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds