[RFC PATCH 12/17] tc35815: Use standard phy_init_hw() instead of BMCR_RESET bit
From: Kyle Moffett <hidden>
Date: 2011-10-20 21:15:43
Also in:
lkml
Subsystem:
networking drivers, the rest · Maintainers:
Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
The PHY should not be manually reset with the BMCR, as that will undo board-specific PHY fixups and driver-specific phy->drv->config_init(). Instead, the PHY should be reset using phy_init_hw(). NOTE: Depends on earlier phy_init_hw() patch. Not-yet-Signed-off-by: Kyle Moffett [off-list ref] --- drivers/net/tc35815.c | 15 ++------------- 1 files changed, 2 insertions(+), 13 deletions(-)
diff --git a/drivers/net/tc35815.c b/drivers/net/tc35815.c
index 4a55a16..c3422f8 100644
--- a/drivers/net/tc35815.c
+++ b/drivers/net/tc35815.c@@ -1175,19 +1175,8 @@ static void tc35815_restart(struct net_device *dev) { struct tc35815_local *lp = netdev_priv(dev); - if (lp->phy_dev) { - int timeout; - - phy_write(lp->phy_dev, MII_BMCR, BMCR_RESET); - timeout = 100; - while (--timeout) { - if (!(phy_read(lp->phy_dev, MII_BMCR) & BMCR_RESET)) - break; - udelay(1); - } - if (!timeout) - printk(KERN_ERR "%s: BMCR reset failed.\n", dev->name); - } + if (lp->phy_dev) + phy_init_hw(lp->phy_dev); spin_lock_bh(&lp->rx_lock); spin_lock_irq(&lp->lock);
--
1.7.2.5