Re: [PATCH] Fix guest memory leak and panic

Ian Campbell [off-list ref] wrote on 10/18/2011 03:17:11 PM:

quoted

I think the best thing might be to remove the additional ref taking

from

quoted

the setter function and audit the previous changes to ensure they
conform. I'll do that right away and post a fixup patch ASAP.

Sigh, only one out of the ten callers of (__)skb_frag_set_page expects
skb_frag_set_page to take a new reference. I think that's pretty
comprehensive evidence that the current behaviour is unexpected and
wrong.

Looks good!

Does it make sense to commit both of these patches? The
reason being - my patch becomes a cleanup of set_skb_frag()
in virtio_net driver.

thanks,

- KK