Re: [PATCH] net-proc: expose the tos values in /proc/net/[tcp|udp]
From: Eric Dumazet <hidden>
Date: 2011-10-05 09:34:18
Also in:
lkml
Subsystem:
networking [general], networking [tcp], the rest · Maintainers:
"David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Neal Cardwell, Linus Torvalds
Le mardi 04 octobre 2011 à 10:38 -0700, MuraliRaja Muniraju a écrit :
I shall make the changes by exposing the tos values via the netlink as suggested. I had a doubt is I have to modify the inet_diag_sockid or export it via a new option. I am considering that adding into inet_diag_sockid is better because the latter is a bit of a over kill for a single value to be exposed and it also seems to be logical fit. Can you let me know your thoughts on this.
I believe you could add one "u32 tos" to struct tcp_info [ It wont solve the UDP case, since "ss -u" still dumps /proc/net/udp and /proc/net/udp6 ] Following patch should handle tcp/dccp ipv4/ipv6
diff --git a/include/linux/tcp.h b/include/linux/tcp.h
index 7f59ee9..eec6f3b 100644
--- a/include/linux/tcp.h
+++ b/include/linux/tcp.h@@ -167,6 +167,7 @@ struct tcp_info { __u32 tcpi_rcv_space; __u32 tcpi_total_retrans; + __u32 tos; }; /* for TCP_MD5SIG socket option */
diff --git a/net/dccp/diag.c b/net/dccp/diag.c
index b21f261..70d9498 100644
--- a/net/dccp/diag.c
+++ b/net/dccp/diag.c@@ -37,6 +37,7 @@ static void dccp_get_info(struct sock *sk, struct tcp_info *info) if (dp->dccps_hc_tx_ccid != NULL) ccid_hc_tx_get_info(dp->dccps_hc_tx_ccid, sk, info); + info->tos = inet_sk(sk)->tos; } static void dccp_diag_get_info(struct sock *sk, struct inet_diag_msg *r,
diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
index 4c0da24..b24c3d8 100644
--- a/net/ipv4/tcp.c
+++ b/net/ipv4/tcp.c@@ -2493,6 +2493,7 @@ void tcp_get_info(struct sock *sk, struct tcp_info *info) info->tcpi_rcv_space = tp->rcvq_space.space; info->tcpi_total_retrans = tp->total_retrans; + info->tos = inet_sk(sk)->tos; } EXPORT_SYMBOL_GPL(tcp_get_info);