On Monday 31 October 2011 08:38:39 Robert Marklund wrote:

ChangeLog v3->v4:
- Remove dual prints and old comment on Mike's request.
- Split the request_free fucntion on Mike and Sascha request.

would be nice if the enable/disable were split as well ...

 	iounmap(pdata->ioaddr);

+	(void)smsc911x_enable_disable_resources(pdev, false);

i don't think the (void) cast is necessary

otherwise looks fine
-mike