From: Daniel Baluta <redacted>
Date: Sat, 29 Oct 2011 00:35:24 +0300

On Sat, Oct 29, 2011 at 12:19 AM, David Miller [off-list ref] wrote:

quoted

From: Daniel Baluta <redacted>
Date: Sat, 29 Oct 2011 00:14:03 +0300

quoted

+static inline int tcp_delack_thresh(const struct sock *sk)
+{
+     return inet_csk(sk)->icsk_ack.rcv_mss * sysctl_tcp_delack_segs;
+}
+

Please turn this into a shift or something, you're adding a multiply
into a core code path.

Is there any generic API to do this? Default case is not
affected since tcp_delack_segs is 1.

I'm saying make the tunable a shift count instead of something to
multiply against.