Thread (9 messages) flat view 9 messages, 3 authors, 2011-10-17

Re: [net-next 5/5] igbvf: convert to ndo_fix_features

From: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Date: 2011-10-16 22:08:22

On Sun, Oct 16, 2011 at 01:37:03PM -0700, Jeff Kirsher wrote:
From: Michał Mirosław <mirq-linux@rere.qmqm.pl>

Private rx_csum flags are now duplicate of netdev->features & NETIF_F_RXCSUM.
Removing this needs deeper surgery.

Things noticed:
 - HW VLAN acceleration probably can be toggled, but it's left as is
 - the resets on RX csum offload change can probably be avoided
 - there is A LOT of copy-and-pasted code here

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: Jeff Kirsher <redacted>
[patch cut]

Great news!

This is the last brick needed for ethtool cleanup. After Dave takes this
one in I'll start dusting off the patches that introduce netif_features_t
and extend it to 64 bits.

Best Regards,
Michał Mirosław
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help