Re: about phonet pipe controller

Le Mercredi 12 Octobre 2011 09:25:01 ext Hemant-vilas RAMDASI a écrit :

You have mentioned in the
"a015f6f: Phonet: kill the ST-Ericsson pipe controller Kconfig",
that "Support for manually enabling the pipe flow is removed as it
did not work properly, does not fit well with the socket API, and
I am not aware of any use at the moment.."

On STE U8500 modem, you must first create pipe in disabled state, then do
local link configuration (does't work when pipe is enabled) & then enable
pipe.

The Kconfig option broke support for existing hardware (Nokia N900 as a USB 
gadget) and userspace (namely the oFono ISI driver). We cannot expect 
distributions to provide two different kernel builds for different flavors of ISI 
modems.

Because of this connect() cannot be used anymore and it needs to be modified
to reintroduce pipe-controller functionality again.

As far as I can tell, that code NEVER worked properly. Not only the use of a 
build-time option is inappropriate, but the code did not deal with a number of 
new corner cases that it introduced.

Do you have any suggestions?

I'm sorry but I don't really get where you're trying to get. The code had more 
bugs than I could fix by myself, especially when I don't have the hardware and 
the specification.

-- 
Rémi Denis-Courmont
http://www.remlab.net/