Thread (20 messages) 20 messages, 4 authors, 2011-10-10

Re: [net-next 02/11] igb: Use node specific allocations for the q_vectors and rings

flat view

From: David Miller <davem@davemloft.net>
Date: 2011-10-08 19:52:08

From: Jeff Kirsher <redacted>
Date: Fri,  7 Oct 2011 23:47:32 -0700
From: Alexander Duyck <redacted>

This change is meant to update the ring and vector allocations so that they
are per node instead of allocating everything on the node that
ifconfig/modprobe is called on.  By doing this we can cut down
significantly on cross node traffic.

Signed-off-by: Alexander Duyck <redacted>
Tested-by:  Aaron Brown  <redacted>
Signed-off-by: Jeff Kirsher <redacted>
adapter->node seems superfluous.

It's always "-1" when we enter the allocation functions, and we
always restore it to it's original value upon exit from such
functions.

Just get rid of it and use a local variable in these functions
to keep track of the current allocation node.

Also, what ensures that MSI-X interrupts are targetted to a cpu
on the the node where you've made these allocations?  I was
pretty sure Ben Hutchings added infrastructure that's usable
to ensure this, but I can't see where you're using it.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help