Thread (7 messages) 7 messages, 4 authors, 2011-10-05

Re: [PATCH 2/2] IPVS netns shutdown/startup dead-lock (Take II)

From: Julian Anastasov <ja@ssi.bg>
Date: 2011-10-03 20:55:02
Also in: lvs-devel, netfilter-devel

	Hello,

On Mon, 3 Oct 2011, Hans Schillstrom wrote:
From: Hans Schillstrom <redacted>

ip_vs_mutext is used by both netns shutdown code and startup
and both implicit uses sk_lock-AF_INET mutex.

cleanup CPU-1         startup CPU-2
ip_vs_dst_event()     ip_vs_genl_set_cmd()
 sk_lock-AF_INET     __ip_vs_mutex
                     sk_lock-AF_INET
__ip_vs_mutex
* DEAD LOCK *

A new mutex placed in ip_vs netns struct called sync_mutex is added.

Comments from Julian and Simon added.
This patch has been running for more than 3 month now and it seems to work.
	May be IP_VS_SO_GET_DAEMON in do_ip_vs_get_ctl
must be protected by sync_mutex in a similar way.

Regards

--
Julian Anastasov [off-list ref]
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help