Re: [patch net-next-2.6 v3] net: consolidate and fix ethtool_ops->get_settings calling

On 9/5/2011 8:25 PM, Zou, Yi wrote:

quoted

On Sat, 2011-09-03 at 15:34 +0200, Jiri Pirko wrote:

quoted

This patch does several things:
- introduces __ethtool_get_settings which is called from ethtool code

and

quoted

   from drivers as well. Put ASSERT_RTNL there.
- dev_ethtool_get_settings() is replaced by __ethtool_get_settings()
- changes calling in drivers so rtnl locking is respected. In
   iboe_get_rate was previously ->get_settings() called unlocked. This
   fixes it. Also prb_calc_retire_blk_tmo() in af_packet.c had the same
   problem. Also fixed by calling __dev_get_by_index() instead of
   dev_get_by_index() and holding rtnl_lock for both calls.
- introduces rtnl_lock in bnx2fc_vport_create() and fcoe_vport_create()
   so bnx2fc_if_create() and fcoe_if_create() are called locked as they
   are from other places.
- use __ethtool_get_settings() in bonding code

Signed-off-by: Jiri Pirko<redacted>

Reviewed-by: Ben Hutchings<redacted>  [except FCoE bits]

Ben.

FCoE bits look ok to me. Thanks,

Reviewed-by: Yi Zou<redacted>

bnx2fc changes looks OK to me.
Reviewed-by: Bhanu Prakash Gollapudi <redacted>

quoted

--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html