2011/09/30 15:55, Nobuhiro Iwamatsu wrote:

2011/9/30 Yoshihiro Shimoda [off-list ref]:

< snip >

quoted

+#include <linux/kernel.h>
+#include <linux/spinlock.h>

These are not required.

The Documentation/SubmitChecklist says the following:

========================================================
1: If you use a facility then #include the file that defines/declares
   that facility.  Don't depend on other header files pulling in ones
   that you use.
========================================================

The sh_eth driver uses spinlock functions and some macros of kernel.h.
So, I think that I have to write their "#include" in the driver.

Best regards,
Yoshihiro Shimoda

Best regards,
  Nobuhiro
Nobuhiro Iwamatsu