Re: [PATCH] RDSRDMA: Fix cleanup of rds_iw_mr_pool
flat view
From: David Miller <davem@davemloft.net>
Date: 2011-09-27 05:32:53
From: Jonathan Lallinger <redacted> Date: Tue, 13 Sep 2011 14:41:01 -0500
quoted hunk ↗ jump to hunk
@@ -548,6 +550,7 @@ static int rds_iw_flush_mr_pool(struct rds_iw_mr_pool *pool, int free_all) spin_unlock_irqrestore(&pool->list_lock, flags); } + atomic_sub(unpinned, &poll->free_pinned); atomic_sub(ncleaned, &pool->dirty_count); atomic_sub(nfreed, &pool->item_count);
net/rds/iw_rdma.c: In function ‘rds_iw_flush_mr_pool’: net/rds/iw_rdma.c:553:24: error: ‘poll’ undeclared (first use in this function) net/rds/iw_rdma.c:553:24: note: each undeclared identifier is reported only once for each function it appears in If you didn't even build test it, I know you didn't test it's functionality either. This is crazy. Well if it's not important enough to even build test this change before you post it, then it obviously doesn't matter if the RDMA module crashes the kernel when it's unloaded.