RE: [net-next 05/10] if_link: Add additional parameter to IFLA_VF_INFO for spoof checking

-----Original Message-----
From: Stephen Hemminger [mailto:shemminger@vyatta.com]
Sent: Monday, September 26, 2011 9:14 AM
To: Ben Hutchings
Cc: Kirsher, Jeffrey T; davem@davemloft.net; Rose, Gregory V;
netdev@vger.kernel.org; gospo@redhat.com
Subject: Re: [net-next 05/10] if_link: Add additional parameter to
IFLA_VF_INFO for spoof checking

On Sun, 25 Sep 2011 21:06:49 +0100
Ben Hutchings [off-list ref] wrote:

quoted

On Sun, 2011-09-25 at 10:22 -0700, Stephen Hemminger wrote:

quoted

On Sat, 24 Sep 2011 02:17:38 -0700
Jeff Kirsher [off-list ref] wrote:

quoted

From: Greg Rose <redacted>

Add configuration setting for drivers to turn spoof checking on or

off

quoted

quoted

quoted

for discrete VFs.

Signed-off-by: Greg Rose <redacted>
Signed-off-by: Jeff Kirsher <redacted>
---
 include/linux/if_link.h   |    7 +++++++
 include/linux/netdevice.h |    3 +++
 net/core/rtnetlink.c      |   25 ++++++++++++++++++++++---
 3 files changed, 32 insertions(+), 3 deletions(-)

diff --git a/include/linux/if_link.h b/include/linux/if_link.h
index 0ee969a..8bd6d6d 100644
--- a/include/linux/if_link.h
+++ b/include/linux/if_link.h

@@ -279,6 +279,7 @@ enum {
 	IFLA_VF_MAC,		/* Hardware queue specific attributes

*/

quoted

quoted

quoted

 	IFLA_VF_VLAN,
 	IFLA_VF_TX_RATE,	/* TX Bandwidth Allocation */
+	IFLA_VF_SPOOFCHK,	/* Spoof Checking on/off switch */
 	__IFLA_VF_MAX,
 };

@@ -300,12 +301,18 @@ struct ifla_vf_tx_rate {
 	__u32 rate; /* Max TX bandwidth in Mbps, 0 disables throttling

*/

quoted

quoted

quoted

 };

+struct ifla_vf_spoofchk {
+	__u32 vf;
+	__u32 setting;
+};
+
 struct ifla_vf_info {
 	__u32 vf;
 	__u8 mac[32];
 	__u32 vlan;
 	__u32 qos;
 	__u32 tx_rate;
+	__u32 spoofchk;
 };

This breaks ABI compatibility, unless you add some special case code
to handle the case of tools sending the old ifla_vf_info. Users may

have older version

quoted

quoted

of ip utilities that send smaller size structure.

Unless I'm missing something, that structure is not sent or received by
userland; that's why I thought it should be #ifdef __KERNEL__.

The struct ifla_vf_info is exposed to userland, it is not inside the
#ifdef
and therefore exposed.

But it is probably okay to change this structure because the ifla_vf_info
is not used/supported by any released version iproute2.  There may have
been
some patches to use this, but they never made it into the git or released
code.

I will respin the patches with *ifdef __KERNEL__ wrapper.

Thanks,

- Greg