RE: [net-next 1/8] pci: Add flag indicating device has been assigned by KVM

-----Original Message-----
From: Konrad Rzeszutek Wilk [mailto:konrad.wilk@oracle.com]
Sent: Friday, September 23, 2011 9:43 AM
To: Kirsher, Jeffrey T
Cc: Rose, Gregory V; Ian Campbell; davem@davemloft.net; Jesse Barnes;
netdev@vger.kernel.org; gospo@redhat.com; linux-pci@vger.kernel.org
Subject: Re: [net-next 1/8] pci: Add flag indicating device has been
assigned by KVM

On Fri, Sep 23, 2011 at 08:45:09AM -0700, Jeff Kirsher wrote:

quoted

On Fri, 2011-09-23 at 08:11 -0700, Rose, Gregory V wrote:

quoted

quoted

-----Original Message-----
From: Ian Campbell [mailto:ijc@hellion.org.uk]
Sent: Friday, September 23, 2011 8:04 AM
To: Rose, Gregory V
Cc: Kirsher, Jeffrey T; davem@davemloft.net; konrad.wilk@oracle.com;

Jesse

quoted

quoted

quoted

Barnes; netdev@vger.kernel.org; gospo@redhat.com; linux-
pci@vger.kernel.org
Subject: RE: [net-next 1/8] pci: Add flag indicating device has been
assigned by KVM

On Fri, 2011-09-23 at 07:41 -0700, Rose, Gregory V wrote:

quoted

quoted

-----Original Message-----
From: Ian Campbell [mailto:ijc@hellion.org.uk]
Sent: Friday, September 23, 2011 12:28 AM
To: Kirsher, Jeffrey T
Cc: davem@davemloft.net; konrad.wilk@oracle.com; Jesse Barnes;

Rose,

quoted

quoted

quoted

quoted

quoted

Gregory V; netdev@vger.kernel.org; gospo@redhat.com; linux-
pci@vger.kernel.org
Subject: Re: [net-next 1/8] pci: Add flag indicating device has

been

quoted

quoted

quoted

quoted

quoted

assigned by KVM

I suppose by that measure the comment could be less KVM

specific:

quoted

quoted

quoted

quoted

quoted

quoted

+       /* Provide indication device is assigned by KVM */
+       PCI_DEV_FLAGS_ASSIGNED = (__force pci_dev_flags_t) 4,

We can resubmit with a more generic comment, maybe this:

/* Provide indication device is assigned by a Virtual Machine

Manager */

quoted

quoted

quoted

Sounds good to me.

Dave, Jeff,

Should I resubmit the patch or would it be more convenient to post a

follow on patch that fixes up the comment?  Either way is fine by me.

quoted

quoted

- Greg

let's fix up the patch in my tree and add Jesse Barnes's ACK at the same
time.

Were are the patches now? I am kind of curious to see the changes to the
xen pciback.

Version 2 of this patch with the modified comment was just posted to netdev.  Ian Campbell had mentioned that the Xen pciback driver should be modified to use this flag but I don't believe any patches for it have been created yet.

- Greg