Re: [RFC, 1/2] ethtool: Implement private flags interface for ethtool application.

W dniu 2 września 2011 23:17 użytkownik Michał Mirosław
[off-list ref] napisał:

2011/9/2 Wyborny, Carolyn [off-list ref]:

quoted

quoted

-----Original Message-----
From: David Miller [mailto:davem@davemloft.net]
Sent: Friday, September 02, 2011 1:55 PM
To: Wyborny, Carolyn
Cc: <redacted>; <redacted>
Subject: Re: [RFC, 1/2] ethtool: Implement private flags interface for
ethtool application.

From: Carolyn Wyborny <redacted>
Date: Fri,  2 Sep 2011 13:50:30 -0700

quoted

This patch completes the user space implementation of the private
flags inteface in ethtool. Using -b/-B options.

Signed-off-by: Carolyn Wyborny <redacted>

The only use case you show here is something generic which other
chips have, Energy Efficient Ethernet.

Making an attribute private which is present widely amonst various
networking chips makes no sense at all.

It deserved a generic ethtool flag.

Fair enough on this particular feature, but does that negate the implementation suggestion altogether?  I can send an updated feature implementation for the use case using DMA Coalescing if that will help.

I would rather see this as an extension to ETHTOOL_[GS]FEATURES. Its
semantics allow easy expanding to handle device-private flags without
changing anything on userspace side.

BTW, After pending Intel drivers get converted to ndo_set_features and
netdev->features get extended to 64 bits, it would also be possible to
use some of the unused bits there for device/driver-private flags
almost "for free".

Best Regards,
Michał Mirosław