Re: [PATCH 2/3] drivers/staging/rtl8192e: Don't pass huge struct by value

On Fri, Aug 12, 2011 at 06:25:56PM -0500, Larry Finger wrote:

On 08/12/2011 06:04 PM, Jesper Juhl wrote:

quoted

From: Jesper Juhl<redacted>
Date: Sat, 13 Aug 2011 00:52:32 +0200

struct ieee80211_network is fairly large (more than half a kilobyte),
so let's pass a pointer instead of passing the entire structure by
value when ieee80211_is_54g() and ieee80211_is_shortslot() need to
look at a few members.
Also remove parentheses around the values being returned from those
two functions - 'return' is not a function.

Signed-off-by: Jesper Juhl<redacted>
---
 drivers/staging/rtl8192e/ieee80211/ieee80211.h     |    4 ++--
 .../staging/rtl8192e/ieee80211/ieee80211_softmac.c |   14 +++++++-------
 2 files changed, 9 insertions(+), 9 deletions(-)

This patch is a good one; however, in Greg's pile of unmerged
patches is a completely different driver for the RTL8192E. The new
driver has the advantage of being organized much more like the
drivers in rtlwifi. That will make it easier to convert to mac80211
and move to mainline.

I also have a lot of unsubmitted patches to clean up the code in the
new driver. At the moment, it is clear of 'checkpatch -f' errors,
and most warnings. In addition, many of the sparse warnings are
fixed. Once Greg merges the patches already submitted, I will send
the others.

Ick, I give up.

Larry, can you resend me _all_ pending rtl8192e patches that you have
sent me that I should apply, in the order they should be applied in, as
I'm totally lost here and have now flushed all of the rtl8192e patches
that were in my inboxes out so I can start with a clean slate.

Sorry about this, the different versions of patches floating around
didn't help anything :(

greg k-h