Re: [PATCH 68/75] hv: netvsc: convert to SKB paged frag API.

On Fri, 2011-08-19 at 14:37 +0100, Dan Carpenter wrote:

On Fri, Aug 19, 2011 at 02:27:40PM +0100, Ian Campbell wrote:

quoted

 	/* usually there's just one frag */
-	skb_frag_set_page(skb, 0, gl->frags[0].page);
+	skb_frag_set_page(skb, 0, gl->frags[0].page.p);	/* XXX */

There are bunch of new /* XXX */ comments.  What are they for?

They are a reminder referring to the dilemma I mentioned in the intro
mail. Basically that ".p" is ugly because gl->frags[0].page isn't
actually a paged fragment, it's just that this driver uses skb_frag_t in
its internal datastructures.

Ian.