Re: [Patch] Scm: Remove unnecessary pid & credential references in Unix socket's send and receive path
flat view
From: David Miller <davem@davemloft.net>
Date: 2011-08-19 05:04:37
Also in:
lkml
From: Tim Chen <redacted> Date: Wed, 17 Aug 2011 16:56:14 -0700
quoted hunk ↗ jump to hunk
+static __inline__ void scm_release(struct scm_cookie *scm) +{ + /* keep ref on pid and cred */ + scm->pid = NULL; + scm->cred = NULL; + if (scm && scm->fp) + __scm_destroy(scm); +}
After dereferencing scm-> already, it seems a big redundant to test it subsequently against NULL.