Re: [PATCH 06/11] drivers/net/bna: do not use EXTRA_CFLAGS
flat view
From: Arnaud Lacombe <hidden>
Date: 2011-08-15 05:17:03
Also in:
lkml
Hi, On Mon, Aug 15, 2011 at 1:07 AM, Arnaud Lacombe [off-list ref] wrote:
Usage of these flags has been deprecated for nearly 4 years by:
commit f77bf01425b11947eeb3b5b54685212c302741b8
Author: Sam Ravnborg <sam@neptun.(none)>
Date: Mon Oct 15 22:25:06 2007 +0200
kbuild: introduce ccflags-y, asflags-y and ldflags-y
Moreover, these flags (at least EXTRA_CFLAGS) have been documented for command
line use. By default, gmake(1) do not override command line setting, so this is
likely to result in build failure or unexpected behavior.
Replace their usage by Kbuild's `{as,cc,ld}flags-y'.
Cc: Sam Ravnborg <redacted>
Cc: Rasesh Mody <redacted>
Cc: netdev@vger.kernel.orgSigned-off-by: Arnaud Lacombe <redacted> - Arnaud
quoted hunk ↗ jump to hunk
--- drivers/net/bna/Makefile | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)diff --git a/drivers/net/bna/Makefile b/drivers/net/bna/Makefile index a5d604d..babc25f 100644 --- a/drivers/net/bna/Makefile +++ b/drivers/net/bna/Makefile@@ -8,4 +8,4 @@ obj-$(CONFIG_BNA) += bna.obna-objs := bnad.o bnad_ethtool.o bna_ctrl.o bna_txrx.o bna-objs += bfa_ioc.o bfa_ioc_ct.o bfa_cee.o cna_fwimg.o -EXTRA_CFLAGS := -Idrivers/net/bna +ccflags-y := -Idrivers/net/bna -- 1.7.6.153.g78432