Re: [PATCH] gianfar: reduce stack usage in gianfar_ethtool.c

From: Joe Perches <joe@perches.com>
Date: 2011-08-10 02:28:41
Also in: lkml

On Wed, 2011-08-10 at 10:29 +0800, stufever@gmail.com wrote:

Signed-off-by: Wang Shaoyan <redacted>

[]

diff --git a/drivers/net/gianfar_ethtool.c b/drivers/net/gianfar_ethtool.c

[]

@@ -686,10 +686,21 @@ static int gfar_ethflow_to_filer_table(struct gfar_private *priv, u64 ethflow, u

[]

+	if (!local_rqfpr || !local_rqfcr) {
+		pr_err("Out of memory\n");
+		ret = 0;
+		got err;

"got err" is true.

Please compile test your patches before sending them.