Re: [PATCH] gianfar: reduce stack usage in gianfar_ethtool.c

Le mardi 09 août 2011 à 11:12 -0700, Joe Perches a écrit :

On Tue, 2011-08-09 at 19:59 +0200, Eric Dumazet wrote:

quoted

Le mardi 09 août 2011 à 10:52 -0700, Joe Perches a écrit :

quoted

On Tue, 2011-08-09 at 18:53 +0200, Eric Dumazet wrote:

quoted

Le mercredi 10 août 2011 à 00:39 +0800, stufever@gmail.com a écrit :

[]

quoted

quoted

+	if (!local_rqfpr || !local_rqfcr) {
+		pr_err("Out of memory\n");

	Please remove this pr_err(), kmalloc() will complain already.

Always?
I know there's a trace option, but is it always on?

Yes, unless caller added ___GFP_NOWARN in gfp :
ptr = kmalloc(size, GFP_KERNEL | ___GFP_NOWARN);

Isn't that true only for slub?

nope, this is page allocation, so common to slab/slub/...

Do you know where this get emitted?
I looked cursorily but I don't see it.

This is a bit beyond this thread

Look at mm/page_alloc.c

void warn_alloc_failed(gfp_t gfp_mask, int order, const char *fmt, ...)